Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maidr package logo #357

Merged
merged 6 commits into from
Feb 14, 2024
Merged

chore: add maidr package logo #357

merged 6 commits into from
Feb 14, 2024

Conversation

SK-143381
Copy link
Collaborator

@SK-143381 SK-143381 commented Jan 20, 2024

Pull Request

Description

Created the logo for the project.

Changes Made

Added the jpg and svg file for the logo

closes #313

@SK-143381 SK-143381 mentioned this pull request Jan 20, 2024
@jooyoungseo jooyoungseo changed the title Logo chore: Added maidr package logo Jan 20, 2024
@jooyoungseo
Copy link
Member

@SK-143381 Please take a look at the new title and how I linked this PR with the issue. 1) Please use conventional commits style in the PR title; 2) please use "closes #issue_number" at the end of your PR message body like I did above.

@jooyoungseo jooyoungseo changed the title chore: Added maidr package logo feat: add maidr package logo Feb 8, 2024
@jooyoungseo jooyoungseo changed the title feat: add maidr package logo chore: add maidr package logo Feb 8, 2024
@jooyoungseo
Copy link
Member

@SK-143381 Please review this alt text and see if there is any improvement or clarity needed: https://github.com/sk-143381/maidr/blob/c3ad97a2b993495dbfef26af1983666294be037f/README.md#L3-L4

Copy link
Member

@jooyoungseo jooyoungseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jooyoungseo jooyoungseo merged commit d5ec666 into xability:main Feb 14, 2024
1 check failed
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make maidr logo
3 participants