Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Individual Start Nodes to Circle and Star #4554

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cybercop23
Copy link
Collaborator

There will be part 2 for the Matrix

There's a new read only Attribute, TotalNodes, that's the sum of all layers. Node counts comes from that sum
Added logic (best it can do for abckwars support) to set parm1/parm2 based on any changes to layers and ports
Allow user to enter nodes for a single layer -> since that's where the total nodes come from

@dkulp
Copy link
Member

dkulp commented Jun 10, 2024

I kind of think this needs a little work, but possibly just in the order of the properties in the panel. It seems like the definitions of the strings is done before the number of nodes is set which then doesn't really work. I'm wondering if the "Layers" setting should be moved up to the top (and Total Nodes then just below it) so you define the "Star" first, then set the string properties for how it's connected.

@cybercop23
Copy link
Collaborator Author

cybercop23 commented Jun 11, 2024

Does this work? Or move string even further down, maybe even after Controller?
image

image

@cybercop23
Copy link
Collaborator Author

Okay.. so something broke with switching those around (unlikely) or I screwed up my original commit and things don't work as they should. Digging into it.

- fixed custom model issue
- added "reset" logic to clear properties when going back to one string
@cybercop23
Copy link
Collaborator Author

Figured out the issue, it was due to the redesign and moving string definition around, plus fixed custom model and make resetting to original format easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants