Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add general CI and integration with mean #190

Draft
wants to merge 18 commits into
base: next_release
Choose a base branch
from

Conversation

smishr
Copy link
Contributor

@smishr smishr commented Jan 22, 2023

EDIT: 26.02.23
Remaining to do on this PR. Integration with other summary functions (total etc) can be done in separate PR's. See their issues

  • Add doctests
  • Review code formulae with theory/textbook

Doing #184

Currently testing integration with mean.

Finding way to integrate with least amount of changes in existing API.

@smishr smishr added the enhancement New feature or request label Jan 22, 2023
@smishr smishr self-assigned this Jan 22, 2023
@smishr smishr changed the title WIP: Add general CI WIP: Add general CI Jan 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v0.1.1@4fac910). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             v0.1.1      #190   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        13           
  Lines             ?       224           
  Branches          ?         0           
==========================================
  Hits              ?       224           
  Misses            ?         0           
  Partials          ?         0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

src/mean.jl Outdated Show resolved Hide resolved
@smishr smishr changed the base branch from singledesign to main January 31, 2023 04:58
@smishr
Copy link
Contributor Author

smishr commented Feb 5, 2023

@ayushpatnaikgit please see how i integrated confidence intervals into mean.jl now

@smishr smishr changed the base branch from main to v0.1.1 February 19, 2023 05:45
@smishr smishr removed their assignment Feb 20, 2023
@smishr
Copy link
Contributor Author

smishr commented Feb 20, 2023

@itsdebartha you may continue this PR, just like mean, add CI functionalities for total quantile and ratio in their respective files

@smishr smishr added the good first issue Good for newcomers label Feb 23, 2023
@smishr smishr linked an issue Feb 23, 2023 that may be closed by this pull request
@smishr smishr changed the title WIP: Add general CI WIP: Add general CI and intergration with mean Feb 26, 2023
@smishr smishr changed the title WIP: Add general CI and intergration with mean WIP: Add general CI and integration with mean Feb 26, 2023
@smishr smishr assigned smishr and nadiaenh and unassigned sayantikaSSG Feb 27, 2023
@smishr smishr deleted the branch xKDR:next_release April 10, 2023 06:02
@smishr smishr closed this Apr 10, 2023
@smishr smishr reopened this Apr 10, 2023
@smishr smishr changed the base branch from v0.1.1 to next_release April 10, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

general CI function
5 participants