Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace poseidon impl with type-rs #630

Conversation

thetheveloper
Copy link
Contributor

@thetheveloper thetheveloper commented Jul 16, 2024

Closes #608

Removes current Poseidon implementation & replaces with the one implemented in type-rs

@thetheveloper
Copy link
Contributor Author

@tcoratger the PR is ready for review

ci failed for the same reason the other PRs failed - locally everything was fine, pushing here again it started failing mostly with InvalidNonce or Provider(StarknetError(DuplicateTx)). Could you please take a look if the implementation is in fact correct as all tests are passing locally?

@xJonathanLEI
Copy link
Owner

Somehow these two tests would always say duplicate tx:

  • can_execute_eth_transfer_invoke_v1_with_jsonrpc
  • can_execute_eth_transfer_invoke_v3_with_jsonrpc

It's almost like the sequencer refuses to process those txs and they got stuck.

@xJonathanLEI
Copy link
Owner

I manually bumped the gas price to use that nonce. Should be good again.

@tcoratger tcoratger merged commit f6d339c into xJonathanLEI:master Jul 17, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace Poseidon implementation by types-rs
3 participants