feat: add byte array type and string conversions #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I've JSON rpc related errors, if you have the opportunity to manually trigger the workflow it could be great @xJonathanLEI. Thanks a lot! |
|
I'm thinking that we should introduce a Bytes31 type to ensure that the EDIT: useless question sorry, will implement it in the PR. 👍 |
glihm
force-pushed
the
feat/type-byte-array
branch
from
955820f to
0ddf5f4
Compare
|
@xJonathanLEI here's the updated version of the PR. Few months of blank here, sorry for that. I've added the Happy to address any comment! |
|
@xJonathanLEI rebased on master, happy to dive in any update as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at bringing support for ByteArray type.