Merge BlockCore @version 1.1.40 #48
Annotations
1 error and 12 warnings
|
Unit Test
Process completed with exit code 1.
|
|
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Build:
src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
|
|
Build:
src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
|
|
Build:
src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/Utilities/AsyncExecutionEvent.cs#L27
Provide an overridable implementation of Dispose(bool) on 'AsyncExecutionEvent' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/Consensus/Chain/ChainRepository.cs#L22
Provide an overridable implementation of Dispose(bool) on 'ChainRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/NBitcoin/BitcoinStream.cs#L22
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/Consensus/ConsensusManager.cs#L29
Provide an overridable implementation of Dispose(bool) on 'ConsensusManager' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/Consensus/ConsensusRuleEngine.cs#L112
Ensure that 'ConsensusRuleEngine.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/Consensus/ConsensusRuleEngine.cs#L22
Provide an overridable implementation of Dispose(bool) on 'ConsensusRuleEngine' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
|
Build:
src/Blockcore/Consensus/FinalizedBlockInfoRepository.cs#L47
Provide an overridable implementation of Dispose(bool) on 'FinalizedBlockInfoRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
|
Loading