Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update node from 12.10.0 to 20.5.0 #57

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Update node from 12.10.0 to 20.5.0 #57

merged 3 commits into from
Jul 27, 2023

Conversation

wzieba
Copy link
Owner

@wzieba wzieba commented Jul 27, 2023 •
edited
Loading

Relates to #54

Originally posted as #55 by @bennettp123. I had to cherry-pick the commit to run the CI checks.

bennettp123 and others added 3 commits July 27, 2023 10:24
@bennettp123 @wzieba
update node from 12.10.0 to 20.5.0
41fccb8 
fixes #54
@wzieba
Set as safe directory
188236e
@wzieba
Remove 'pull_request_target' trigger event
a7817c7 
As this event triggers build against of the base of the pull request,
the build triggered by it will fail when PR fixes already failing build
of the base.
@wzieba
Copy link
Owner Author

wzieba commented Jul 27, 2023

pull_request_target fails as expected. The trigger has been removed in a7817c7. Merging

@wzieba wzieba merged commit 70e33d4 into master Jul 27, 2023
2 of 3 checks passed
@wzieba wzieba deleted the distribute-is-invalid branch July 27, 2023 08:46
@wzieba wzieba mentioned this pull request Jul 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wzieba @bennettp123