Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: <Table> header support #682

Closed

Conversation

juanesquintero
Copy link
Contributor

@juanesquintero juanesquintero commented Aug 18, 2023

Enable <Table/> inner border preview
Add header prop to <Table/>

@juanesquintero
Copy link
Contributor Author

@wyozi Hey Joonas! Do you think is a good approach to insert a header prop or either way implement a full <Table.Cell> component?

@wyozi
Copy link
Owner

wyozi commented Aug 19, 2023

@juanesquintero if I understood correctly the goal of header prop would be making a cell that is as wide as the table. In that case I think a full-on <Table.Cell> would work more nicely here and be a bit more generic

@wyozi
Copy link
Owner

wyozi commented Aug 19, 2023

Looking at pptxgenjs' TableCellProps type, maybe <Table.Cell> could extend <Text> props too and add the extra props (including colspan). But you can experiment a bit and see what works

@juanesquintero
Copy link
Contributor Author

juanesquintero commented Aug 19, 2023

@wyozi Agree with you! Will open a PR with that approach...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants