-
-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(size)!: Switch from tsup
to unbuild
for building WXT
#848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for creative-fairy-df92c4 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aklinker1
changed the title
chore: Switch from
chore: Switch from Jul 23, 2024
tsup
to mkdist
for building WXTtsup
to unbuild
for building WXT
aklinker1
commented
Jul 24, 2024
aklinker1
commented
Jul 24, 2024
aklinker1
changed the title
chore: Switch from
perf(size): Switch from Jul 24, 2024
tsup
to unbuild
for building WXTtsup
to unbuild
for building WXT
aklinker1
changed the title
perf(size): Switch from
perf(size)!: Switch from Jul 24, 2024
tsup
to unbuild
for building WXTtsup
to unbuild
for building WXT
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #848 +/- ##
==========================================
+ Coverage 82.35% 82.43% +0.08%
==========================================
Files 112 112
Lines 6278 6280 +2
Branches 1018 1019 +1
==========================================
+ Hits 5170 5177 +7
+ Misses 1095 1090 -5
Partials 13 13 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Drop CJS support
I was having some weird behavior with dev mode module resolution in #847, and wanted to simplify the build output to see if that would have any effect. Haven't tested it yet, but as you can see below, it's a good change anyways:
Other changes:
~
typscript path, doesn't work withmkdist