Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-ext): Correctly pass browserConsole option to open devtools in Firefox #1308

Merged
merged 1 commit into from
Dec 29, 2024

Conversation

psrpinto
Copy link
Contributor

The browser console does not currently open on Firefox, because wxt is passing the wrong property to web-ext. The property is called browserConsole but wxt was passing console.

See https://github.com/mozilla/web-ext/blob/master/src/cmd/run.js#L25

Copy link

netlify bot commented Dec 27, 2024

Deploy Preview for creative-fairy-df92c4 ready!

Name Link
🔨 Latest commit 58f1cb9
🔍 Latest deploy log https://app.netlify.com/sites/creative-fairy-df92c4/deploys/676e9e780815e2000838bc8a
😎 Deploy Preview https://deploy-preview-1308--creative-fairy-df92c4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Dec 29, 2024

Open in Stackblitz

@wxt-dev/auto-icons

npm i https://pkg.pr.new/@wxt-dev/auto-icons@1308

@wxt-dev/i18n

npm i https://pkg.pr.new/@wxt-dev/i18n@1308

@wxt-dev/module-react

npm i https://pkg.pr.new/@wxt-dev/module-react@1308

@wxt-dev/module-solid

npm i https://pkg.pr.new/@wxt-dev/module-solid@1308

@wxt-dev/module-svelte

npm i https://pkg.pr.new/@wxt-dev/module-svelte@1308

@wxt-dev/module-vue

npm i https://pkg.pr.new/@wxt-dev/module-vue@1308

@wxt-dev/storage

npm i https://pkg.pr.new/@wxt-dev/storage@1308

@wxt-dev/unocss

npm i https://pkg.pr.new/@wxt-dev/unocss@1308

wxt

npm i https://pkg.pr.new/wxt@1308

commit: 58f1cb9

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (b150a52) to head (58f1cb9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/wxt/src/core/runners/web-ext.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1308      +/-   ##
==========================================
- Coverage   81.12%   80.98%   -0.15%     
==========================================
  Files         128      128              
  Lines        6285     6285              
  Branches     1066     1069       +3     
==========================================
- Hits         5099     5090       -9     
- Misses       1171     1180       +9     
  Partials       15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aklinker1 aklinker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aklinker1 aklinker1 changed the title Fix issue that causes browser console to not open fix(web-ext): Correctly pass browserConsole option to open devtools in Firefox Dec 29, 2024
@aklinker1 aklinker1 merged commit 78f97f3 into wxt-dev:main Dec 29, 2024
18 checks passed
@psrpinto psrpinto deleted the patch-1 branch January 6, 2025 11:37
@aklinker1
Copy link
Collaborator

Released in v0.19.24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants