-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Basic CMake Support, Fix Conversion Test Compilation #28
Open
cullvox
wants to merge
5
commits into
wx257osn2:master
Choose a base branch
from
cullvox:cmake_and_windows_fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
973898b
CMake, Windows fixes, Fix compilation of conversion test
cullvox 36966ff
Remove new header, I'll test on windows later.
cullvox 570ef6f
Make the cmake variable string more clear.
cullvox bce289d
remove gitignore, add newline at eof
cullvox 61972d9
Working on adding installs.
cullvox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
cmake_minimum_required(VERSION 3.14) | ||
project(qoixx LANGUAGES CXX) | ||
|
||
option(QOIXX_USE_TABLES "QOIXX will use precomputed tables to increase runtime preformance." ON) | ||
option(QOIXX_BUILD_TESTS "QOIXX will build samples and tests." ON) | ||
|
||
add_library(qoixx INTERFACE) | ||
add_library(qoixx::qoixx ALIAS qoixx) | ||
target_include_directories(qoixx INTERFACE $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/include>) | ||
target_compile_definitions(qoixx INTERFACE QOIXX_DECODE_WITH_TABLES=${QOIXX_USE_TABLES}) | ||
set_target_properties(qoixx PROPERTIES CXX_STANDARD 20) | ||
|
||
if (QOIXX_BUILD_TESTS) | ||
set(STB ".dependencies/stb") | ||
set(QOI ".dependencies/qoi") | ||
set(DOCTEST ".dependencies/doctest/doctest") | ||
|
||
add_executable(qoibench "src/qoibench.cpp") | ||
target_link_libraries(qoibench qoixx::qoixx) | ||
target_include_directories(qoibench PUBLIC ${STB} ${QOI}) | ||
set_target_properties(qoibench PROPERTIES CXX_STANDARD 20) | ||
|
||
add_executable(qoiconv "src/qoiconv.cpp") | ||
target_link_libraries(qoiconv qoixx::qoixx) | ||
target_include_directories(qoiconv PUBLIC ${STB} ${QOI}) | ||
set_target_properties(qoiconv PROPERTIES CXX_STANDARD 20) | ||
|
||
add_executable(qoitest "src/test.cpp") | ||
target_link_libraries(qoitest qoixx::qoixx) | ||
target_include_directories(qoitest PUBLIC ${DOCTEST}) | ||
set_target_properties(qoitest PROPERTIES CXX_STANDARD 20) | ||
|
||
install(TARGETS qoibench qoiconv | ||
RUNTIME DESTINATION "${PROJECT_SOURCE_DIR}/bin") | ||
endif() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will be
-DQOIXX_DECODE_WITH_TABLES=ON
, butQOIXX_DECODE_WITH_TABLES
must be0
or1
. Please fix this