Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding grid support #9

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

abdelaziz-mahdy
Copy link

i added grid support to the code

but i got a problem where the updated flicker

i think the code updates the widgets twice or the multiple list changes makes the ui not consistent

@wwwdata
Copy link
Owner

wwwdata commented Sep 26, 2022

At first look I think we should change a couple of things:

  • Update .gitignore files so the additional unnecessary files from example and so on are ignored (I just rescued this repository from the original maintainer and they were also missing in the old project it seems)
  • I see a lot of copy and paste for the whole logic... This must be made reusable to avoid this.

I also allowed test runs now to check code formatting and so on.

@abdelaziz-mahdy
Copy link
Author

I will try to make it reusable

My only problem was that the grid delgate needs to be passed to the last layer of your classes so it needed to be required in all of them

It can't be optional since this is required in grid view

But I will try to do it

@kvenn
Copy link

kvenn commented May 11, 2024

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants