fix: have enable_subgraph_fetch_operation_name default to false (#1405)

wundergraph · Nov 27, 2024 · 26cdadc · 26cdadc
1 parent d562e89
commit 26cdadc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/router/pkg/config/config.go b/router/pkg/config/config.go
@@ -320,7 +320,7 @@ type EngineExecutionConfiguration struct {
 	EnableValidationCache                  bool                     `envDefault:"true" env:"ENGINE_ENABLE_VALIDATION_CACHE" yaml:"enable_validation_cache"`
 	ValidationCacheSize                    int64                    `envDefault:"10240" env:"ENGINE_VALIDATION_CACHE_SIZE" yaml:"validation_cache_size,omitempty"`
 	ResolverMaxRecyclableParserSize        int                      `envDefault:"32768" env:"ENGINE_RESOLVER_MAX_RECYCLABLE_PARSER_SIZE" yaml:"resolver_max_recyclable_parser_size,omitempty"`
-	EnableSubgraphFetchOperationName       bool                     `envDefault:"true" env:"ENGINE_ENABLE_SUBGRAPH_FETCH_OPERATION_NAME" yaml:"enable_subgraph_fetch_operation_name"`
+	EnableSubgraphFetchOperationName       bool                     `envDefault:"false" env:"ENGINE_ENABLE_SUBGRAPH_FETCH_OPERATION_NAME" yaml:"enable_subgraph_fetch_operation_name"`
 }
 
 type SecurityConfiguration struct {

diff --git a/router/pkg/config/config.schema.json b/router/pkg/config/config.schema.json
@@ -2030,7 +2030,7 @@
         },
         "enable_subgraph_fetch_operation_name": {
             "type": "boolean",
-            "default": true,
+            "default": false,
             "description": "Enable appending the operation name to subgraph fetches. This will ensure that the operation name will be included in the corresponding subgraph requests using the following format: $operationName__$subgraphName__$sequenceID."
         }
       }

diff --git a/router/pkg/config/testdata/config_defaults.json b/router/pkg/config/testdata/config_defaults.json
@@ -244,7 +244,7 @@
     "EnableValidationCache": true,
     "ValidationCacheSize": 10240,
     "ResolverMaxRecyclableParserSize": 32768,
-    "EnableSubgraphFetchOperationName": true
+    "EnableSubgraphFetchOperationName": false
   },
   "WebSocket": {
     "Enabled": true,