Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1611: 404 error is propagated as 500 #1612

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

banterCZ
Copy link
Member

No description provided.

@banterCZ banterCZ requested review from zcgandcomp and jnpsk March 28, 2024 08:10
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project is actually not broken - it returns proper 404 Status.
But we can normalize Error Handling so we avoid the possible problem in the future.
Honestly, usually I stick to the rule "do not repair what is not broken", but I will leave it to you as I can see some benefit of preventing the issue in the future.

@banterCZ
Copy link
Member Author

This project is actually not broken - it returns proper 404 Status. But we can normalize Error Handling so we avoid the possible problem in the future. Honestly, usually I stick to the rule "do not repair what is not broken", but I will leave it to you as I can see some benefit of preventing the issue in the future.

Actually, tpp-engine and next-step return 500. And for webflow, I am also able to get this stacktrace with 500

2024-03-28T10:14:34.785+01:00 ERROR 50863 --- [powerauth-webflow] [nio-9080-exec-4] [31b885708b52300f02573a15f3dd56a2-f7939733fa80e2ab] i.g.s.p.a.w.e.DefaultExceptionResolver   : Error occurred in Web Flow server

org.springframework.web.servlet.resource.NoResourceFoundException: No static resource resources/css/bootstrap.min.css.map.
	at org.springframework.web.servlet.resource.ResourceHttpRequestHandler.handleRequest(ResourceHttpRequestHandler.java:585) ~[spring-webmvc-6.1.5.jar:6.1.5]
	at org.springframework.web.servlet.mvc.HttpRequestHandlerAdapter.handle(HttpRequestHandlerAdapter.java:52) ~[spring-webmvc-6.1.5.jar:6.1.5]
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:1089) ~[spring-webmvc-6.1.5.jar:6.1.5]
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:979) ~[spring-webmvc-6.1.5.jar:6.1.5]
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:1014) ~[spring-webmvc-6.1.5.jar:6.1.5]
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:903) ~[spring-webmvc-6.1.5.jar:6.1.5]
	at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:564) ~[tomcat-embed-core-10.1.19.jar:6.0]
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:885) ~[spring-webmvc-6.1.5.jar:6.1.5]

@banterCZ banterCZ merged commit fd9d573 into develop Apr 2, 2024
5 checks passed
@banterCZ banterCZ deleted the issues/1611-not-found branch April 2, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants