Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1593: Reconfigure OIDC to resource-server #1594

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix #1593: Reconfigure OIDC to resource-server #1594

merged 1 commit into from
Feb 29, 2024

Conversation

banterCZ
Copy link
Member

No description provided.

zcgandcomp
zcgandcomp approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. I was just thinking that we can incorporate configuration for getting role from the claim, but we are not using roles as of now so we can incorporate it later when needed.

@banterCZ banterCZ merged commit ad10a49 into develop Feb 29, 2024
5 checks passed
@banterCZ banterCZ deleted the issues/1593-oidc branch February 29, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcgandcomp zcgandcomp zcgandcomp approved these changes

@romanstrobl romanstrobl Awaiting requested review from romanstrobl

@korbelm korbelm Awaiting requested review from korbelm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@banterCZ @zcgandcomp