Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1412: Review liquibase scripts #1421

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Fix #1412: Review liquibase scripts #1421

merged 4 commits into from
Sep 21, 2023

Conversation

jandusil
Copy link
Contributor

  • Review sequences

@jandusil jandusil self-assigned this Sep 14, 2023
@jandusil jandusil linked an issue Sep 14, 2023 that may be closed by this pull request
Review liquibase scripts #1412
Closed
romanstrobl
romanstrobl requested changes Sep 14, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will probably end up with many errors like this:

ERROR: value "9999999999999999999999999999" is out of range for type bigint

romanstrobl
romanstrobl requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The minValue setting seems to be inconsistent.

zcgandcomp
zcgandcomp approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

romanstrobl
romanstrobl approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@jandusil jandusil merged commit 02cee77 into develop Sep 21, 2023
5 checks passed
@jandusil jandusil deleted the issues/1412-review-liquibase-scripts branch September 21, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanstrobl romanstrobl romanstrobl approved these changes

@zcgandcomp zcgandcomp zcgandcomp approved these changes

@banterCZ banterCZ Awaiting requested review from banterCZ

Assignees

@jandusil jandusil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review liquibase scripts
3 participants
@jandusil @zcgandcomp @romanstrobl