Fix #992: Review liquibase scripts #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Review sequences
- Review foreign keys
- Review indexes
zcgandcomp
requested changes
Sep 1, 2023
- Revert index name changes in audit_log
zcgandcomp
requested changes
Sep 4, 2023
| @@ -70,7 +75,7 @@ | |||
| </not> | |||
| </preConditions> | |||
| <comment>Create a new sequence pa_recovery_puk_seq</comment> | |||
| <createSequence sequenceName="pa_recovery_puk_seq" cacheSize="20" /> | |||
| <createSequence sequenceName="pa_recovery_puk_seq" startValue="1" incrementBy="1" cacheSize="20" type="bigint"/> | |||
There was a problem hiding this comment.
Different type then id in the table
| @@ -80,7 +85,8 @@ | |||
| </not> | |||
| </preConditions> | |||
| <comment>Create a new sequence pa_recovery_config_seq</comment> | |||
| <createSequence sequenceName="pa_recovery_config_seq" cacheSize="20" /> | |||
| <createSequence sequenceName="pa_recovery_config_seq" startValue="1" incrementBy="1" cacheSize="20" | |||
There was a problem hiding this comment.
Different type then id in the table
zcgandcomp
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.