Fix #994: Coverity: Unlogged security exception

wultra · Sep 4, 2023 · b74d341 · b74d341
1 parent 799e961
commit b74d341
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/...tlime/security/powerauth/app/server/service/behavior/tasks/ActivationServiceBehavior.java b/...tlime/security/powerauth/app/server/service/behavior/tasks/ActivationServiceBehavior.java
@@ -188,7 +188,6 @@ private void handleInvalidPublicKey(ActivationRecordEntity activation) throws Ge
         activation.setActivationStatus(ActivationStatus.REMOVED);
         activationHistoryServiceBehavior.saveActivationAndLogChange(activation);
         callbackUrlBehavior.notifyCallbackListenersOnActivationChange(activation);
-        logger.warn("Invalid public key, activation ID: {}", activation.getActivationId());
         // Exception must not be rollbacking, otherwise data written to database in this method would be lost
         throw localizationProvider.buildExceptionForCode(ServiceError.ACTIVATION_NOT_FOUND);
     }
@@ -938,6 +937,8 @@ public PrepareActivationResponse prepareActivation(String activationCode, String
             try {
                 devicePublicKey = keyConversion.convertBytesToPublicKey(devicePublicKeyBytes);
             } catch (InvalidKeySpecException ex) {
+                logger.warn("Invalid public key, activation ID: {}", activation.getActivationId());
+                logger.debug("Invalid public key, activation ID: {}", activation.getActivationId(), ex);
                 handleInvalidPublicKey(activation);
             }