Fix #1016: Inconsistent columns for signature metadata

wultra · Sep 7, 2023 · 994a1ac · 994a1ac
1 parent 2ca408c
commit 994a1ac
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/docs/PowerAuth-Server-1.5.0.md b/docs/PowerAuth-Server-1.5.0.md
@@ -44,23 +44,20 @@ In 1.5.x, we definitely removed the legacy V2 protocol support and only support
 ### Add Signature Data in an Easy to Parse Structure
 
 Add following columns:
- - `signature_data_method` - HTTP method used for the signature verification
- - `signature_data_uri_id` - identifier of given URI of the resource used for the signature verification
+ - `signature_metadata` - metadata related to the signature calculation
  - `signature_data_body` - data used for the signature verification
 
 #### PostgreSQL
 
 ```sql
-ALTER TABLE pa_signature_audit ADD COLUMN signature_data_method VARCHAR(32);
-ALTER TABLE pa_signature_audit ADD COLUMN signature_data_uri_id VARCHAR(255);
+ALTER TABLE pa_signature_audit ADD COLUMN signature_metadata TEXT;
 ALTER TABLE pa_signature_audit ADD COLUMN signature_data_body TEXT;
 ```
 
 #### Oracle
 
 ```sql
-ALTER TABLE PA_SIGNATURE_AUDIT ADD COLUMN SIGNATURE_DATA_METHOD VARCHAR2(32 CHAR);
-ALTER TABLE PA_SIGNATURE_AUDIT ADD COLUMN SIGNATURE_DATA_URI_ID VARCHAR2(255 CHAR);
+ALTER TABLE PA_SIGNATURE_AUDIT ADD COLUMN SIGNATURE_METADATA CLOB;
 ALTER TABLE PA_SIGNATURE_AUDIT ADD COLUMN SIGNATURE_DATA_BODY CLOB;
 ```
 

diff --git a/docs/db/changelog/changesets/powerauth-java-server/1.5.x/20230426-add-column-totp-seed.xml b/docs/db/changelog/changesets/powerauth-java-server/1.5.x/20230426-add-column-totp-seed.xml
@@ -9,7 +9,7 @@
                 <columnExists tableName="pa_operation" columnName="totp_seed"/>
             </not>
         </preConditions>
-        <comment>Add signature_data_method column</comment>
+        <comment>Add totp_seed column</comment>
         <addColumn tableName="pa_operation">
             <column name="totp_seed" type="varchar(24)" />
         </addColumn>
@@ -21,7 +21,7 @@
                 <columnExists tableName="pa_operation_template" columnName="proximity_check_enabled"/>
             </not>
         </preConditions>
-        <comment>Add signature_data_method column</comment>
+        <comment>Add proximity_check_enabled column</comment>
         <addColumn tableName="pa_operation_template">
             <column name="proximity_check_enabled" type="boolean" defaultValueBoolean="false">
                 <constraints nullable="false" />

diff --git a/docs/sql/oracle/create_schema.sql b/docs/sql/oracle/create_schema.sql
@@ -97,8 +97,7 @@ CREATE TABLE "PA_SIGNATURE_AUDIT"
     "NOTE"                    VARCHAR2(255 CHAR),
     "SIGNATURE_TYPE"          VARCHAR2(255 CHAR) NOT NULL,
     "SIGNATURE"               VARCHAR2(255 CHAR) NOT NULL,
-    "SIGNATURE_DATA_METHOD"   VARCHAR2(32 CHAR),
-    "SIGNATURE_DATA_URI_ID"   VARCHAR2(255 CHAR),
+    "SIGNATURE_METADATA"      CLOB,
     "SIGNATURE_DATA_BODY"     CLOB,
     "TIMESTAMP_CREATED"       TIMESTAMP (6) NOT NULL,
     "VALID"                   NUMBER(1,0) DEFAULT 0 NOT NULL,

diff --git a/docs/sql/postgresql/create_schema.sql b/docs/sql/postgresql/create_schema.sql
@@ -98,8 +98,7 @@ CREATE TABLE pa_signature_audit
     note                    VARCHAR(255),
     signature_type          VARCHAR(255) NOT NULL,
     signature               VARCHAR(255) NOT NULL,
-    signature_data_method   VARCHAR(32),
-    signature_data_uri_id   VARCHAR(255),
+    signature_metadata      TEXT,
     signature_data_body     TEXT,
     timestamp_created       TIMESTAMP (6) NOT NULL,
     valid                   BOOLEAN,