Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #670: Review liquibase scripts #671

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

jandusil
Copy link
Contributor

@jandusil jandusil commented Sep 5, 2023

  • Review sequences

@jandusil jandusil requested a review from zcgandcomp September 5, 2023 08:26
@jandusil jandusil self-assigned this Sep 5, 2023
@jandusil jandusil linked an issue Sep 5, 2023 that may be closed by this pull request
@jandusil jandusil requested a review from banterCZ September 5, 2023 08:28
@jandusil jandusil marked this pull request as draft September 5, 2023 08:29
@jandusil jandusil marked this pull request as ready for review September 5, 2023 08:31
@@ -50,7 +50,7 @@
</not>
</preConditions>
<comment>Create a new sequence sequence push_campaign_user_seq</comment>
<createSequence sequenceName="push_campaign_user_seq"/>
<createSequence sequenceName="push_campaign_user_seq" startValue="1" incrementBy="1" cacheSize="20"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zcgandcomp So do we have to specify the incrementBy? Is it also platform-specific?

Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. LB tested on MSSQL and Oracle

@jandusil jandusil merged commit 7aac45e into develop Sep 12, 2023
5 checks passed
@jandusil jandusil deleted the issues/670-review-liquibase-scripts branch September 12, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review liquibase scripts
3 participants