Support for ECIES with temporary keys #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increased protocol version to 3.3
hvge
changed the title
…ptor Docs: Updated documentation
petrdvorak
approved these changes
Sep 11, 2024
| final String challenge = Base64.encodeToString(CryptoUtils.randomBytes(18), Base64.NO_WRAP); | ||
| final GetTemporaryKeyRequest request = new GetTemporaryKeyRequest(applicationKey, activationId, challenge); | ||
| // Prepare JWT string | ||
| final String jwtHeader = "eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9."; // {"alg":"HS256","typ":"JWT"} with dot separator |
| } | ||
|
|
||
| - (id<PowerAuthOperationTask>) signJwtWithDevicePrivateKey:(PowerAuthAuthentication*)authentication | ||
| claims:(NSDictionary<NSString*, NSObject*>*)claims | ||
| callback:(void(^)(NSString *jwt, NSError *error))callback | ||
| { | ||
| // Prepare JWT Header | ||
| NSString * jwtHeader = @"eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9."; // {"alg":"ES256","typ":"JWT"} |
| @@ -2530,22 +2552,16 @@ public void onBiometricDialogFailed(@NonNull PowerAuthErrorException error) { | |||
| @Nullable | |||
| public ICancelable signJwtWithDevicePrivateKey(@NonNull Context context, @NonNull PowerAuthAuthentication authentication, @NonNull Map<String, Object> claims, @NonNull IJwtSignatureListener listener) { | |||
| final JsonSerialization serialization = new JsonSerialization(); | |||
| final byte[] serializedClaims = serialization.serializeObject(claims); | |||
| return signDataWithDevicePrivateKey(context, authentication, serializedClaims, new IDataSignatureListener() { | |||
| final String jwtHeader = "eyJhbGciOiJFUzI1NiIsInR5cCI6IkpXVCJ9"; // {"alg":"ES256","typ":"JWT"} | |||
kober32
approved these changes
Sep 12, 2024
...ndroid/PowerAuthLibrary/src/main/java/io/getlime/security/powerauth/ecies/EciesMetadata.java
Outdated
Show resolved
Hide resolved
| */ | ||
| @Deprecated // 1.9.0 |
There was a problem hiding this comment.
Just to consider - maybe we should just remove these methods instead of deprecation? If someone is coming from an older SDK than 1.8, this will lead to an immediate fail anyway (and possible support request). If the client is coming from 1.8 it will work, but I think the majority of our clients are still on 1.7 and older.
There was a problem hiding this comment.
We have this policy since the beginning of the SDK development. In my own experience, it's better to have a working build immediately after the upgrade and then I can slowly fix the warnings. This of course expects, that the developers have some common standards applied, such as zero warnings build.
...werAuthLibrary/src/main/java/io/getlime/security/powerauth/sdk/impl/GetTemporaryKeyTask.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for PowerAuth protocol version 3.3.