Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added log listener #584

Merged
merged 1 commit into from
May 27, 2024
Merged

Added log listener #584

merged 1 commit into from
May 27, 2024

Conversation

kober32
Copy link
Member

@kober32 kober32 commented Apr 23, 2024

Adding a log listener to be able to tap into logs and log them into file/online system.

More explanation in the issue: #583

@kober32 kober32 requested review from petrdvorak and hvge April 23, 2024 09:09
hvge
hvge approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@hvge hvge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. Just for note, do we have plans also add similar functionality for iOS?

@kober32
Copy link
Member Author

kober32 commented May 27, 2024

Yes, I'll prepare another PR.

@kober32 kober32 merged commit 187c9c2 into develop May 27, 2024
1 check passed
@kober32 kober32 deleted the issues/583-log-listener branch May 27, 2024 12:48
@kober32 kober32 mentioned this pull request May 27, 2024
Merged
hvge added a commit that referenced this pull request Jun 6, 2024
@hvge
Cherry pick: Resolved #583: Added log listener (#584)
cb6d4c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvge hvge hvge approved these changes

@petrdvorak petrdvorak Awaiting requested review from petrdvorak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kober32 @hvge