Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Option to disable error dialog after failed biometry #552

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

hvge
Copy link
Member

@hvge hvge commented Sep 20, 2023

This PR adds option to disable error dialog presented from PowerAuth SDK after biometry fail. If the error dialog is disabled, then application can detect whether failure should be displayed to the user with using new BiometricErrorInfo enumeration, associated to PowerAuthErrorException.

Other changes:

  • Simplified PowerAuthSDK.authenticateWithBiometry(). The authenticate methods now use new IAuthenticateWithBiometryListener that return PowerAuthAuthentication in success.
  • Added support for missing BIOMETRY_NOT_ENROLLED error code (unification with iOS)

Note that documentation doesn't contain new steps for migration to 1.8. This is covered in separate PR #550

- PowerAuthErrorException now may contain an additionalInformation
- Added BiometricErrorInfo

Other changes
- Simplified PowerAuthSDK.authenticateWithBiometry()
- Added support for missing BIOMETRY_NOT_ENROLLED error code (unification with iOS)
@hvge hvge requested a review from kober32 September 20, 2023 10:59
hvge added a commit that referenced this pull request Sep 20, 2023
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK. I marked one naming issue to consider changing.

@hvge hvge merged commit cb40343 into develop Sep 21, 2023
1 check passed
@hvge hvge deleted the issues/523-disable-error-dialog branch September 21, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants