Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change local "commit" to "persist" #549

Merged
merged 4 commits into from
Sep 18, 2023
Merged

Change local "commit" to "persist" #549

merged 4 commits into from
Sep 18, 2023

Conversation

hvge
Copy link
Member

@hvge hvge commented Sep 18, 2023 •
edited
Loading

This PR changes how we call a local activation completion in our terminology and API. The "commit activation" is now "persist activation".

Other changes:

  • Removed interfaces deprecated in 1.7.x

@hvge hvge requested review from petrdvorak and kober32 September 18, 2023 11:40
@hvge hvge marked this pull request as ready for review September 18, 2023 12:06
kober32
kober32 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@hvge hvge merged commit 3dbd907 into develop Sep 18, 2023
1 check passed
@hvge hvge deleted the issues/542-commit-to-persist branch September 18, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 approved these changes

@petrdvorak petrdvorak Awaiting requested review from petrdvorak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvge @kober32