Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for temporary keys #632

Merged
merged 12 commits into from
Aug 27, 2024
Merged

Conversation

petrdvorak
Copy link
Member

No description provided.

@petrdvorak petrdvorak requested a review from hvge July 26, 2024 13:30
Copy link
Member

@hvge hvge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, I found just a minor improvement in the input validation.

@petrdvorak petrdvorak requested review from hvge and banterCZ August 9, 2024 10:23
@romanstrobl romanstrobl self-requested a review August 9, 2024 11:16
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to create utility methods for checking versions than to repeat the same version checks with ||, but we can change that in another pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants