Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #605: Refactor BouncyCastle dependency #606

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix #605: Refactor BouncyCastle dependency #606

merged 1 commit into from
Apr 23, 2024

Conversation

banterCZ
Copy link
Member

  • Make the scope compile instead of provided

@banterCZ
Fix #605: Refactor BouncyCastle dependency
033b046 
- Make the scope compile instead of provided
@banterCZ banterCZ requested review from romanstrobl and jnpsk April 22, 2024 06:35
jnpsk
jnpsk approved these changes Apr 22, 2024
View reviewed changes
Copy link

@jnpsk jnpsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

This was referenced Apr 22, 2024
Merged
Merged
Merged
Merged
romanstrobl
romanstrobl approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test this change with all application servers, especially JBoss/Wildfly and Weblogic.

This was referenced Apr 22, 2024
Merged
Merged
Merged
Merged
@banterCZ
Copy link
Member Author

Please test this change with all application servers, especially JBoss/Wildfly and Weblogic.

This change does not affect JBoss itself. I will test it in PAS wultra/powerauth-server#1476
WebLogic does not yet support EE 9.1 or 10 anyway https://en.wikipedia.org/wiki/Oracle_WebLogic_Server#Standards_support_by_version

@banterCZ banterCZ merged commit cf633d1 into develop Apr 23, 2024
1 check passed
@banterCZ banterCZ deleted the issues/605-bc-dependency branch April 23, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnpsk jnpsk jnpsk approved these changes

@romanstrobl romanstrobl romanstrobl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banterCZ @romanstrobl @jnpsk