Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed R8 missing classes #179

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fixed R8 missing classes #179

wants to merge 3 commits into from

Conversation

Hopsaheysa
Copy link
Member

Fixes #178

-> For inbox model classes added @SerializedName so its rules is applied to these classes

-> the whole api package kept as internal classes in *Api.kt might get thrown away by R8

kober32
kober32 previously approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@kober32 kober32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

TomasKypta
TomasKypta requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@TomasKypta TomasKypta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rules seem too broad.

library/consumer-proguard-rules.pro Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kober32 kober32 kober32 left review comments

@TomasKypta TomasKypta Awaiting requested review from TomasKypta

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve R8 rules
3 participants
@Hopsaheysa @TomasKypta @kober32