Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #137: Error in after.sql #140

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Fix #137: Error in after.sql #140

merged 8 commits into from
Oct 18, 2023

Conversation

banterCZ
Copy link
Member

Use the original table names from 1.1.0

  • mobile_app
  • mobile_ssl_pinning

Use the original table names from 1.1.0
- mobile_app
- mobile_ssl_pinning
@banterCZ banterCZ temporarily deployed to docker-publish October 11, 2023 11:43 — with GitHub Actions Inactive
@banterCZ banterCZ temporarily deployed to docker-publish October 11, 2023 11:59 — with GitHub Actions Inactive
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok.

@banterCZ banterCZ temporarily deployed to docker-publish October 11, 2023 12:24 — with GitHub Actions Inactive
INSERT INTO mus_mobile_app SELECT * FROM mobile_app;

-- For table certificate
INSERT INTO mus_certificate SELECT * FROM mobile_ssl_pinning;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to select columns in a specific order and also insert them into mus_mobile_domain. Moreover, we have to fill the pem column.

@banterCZ banterCZ temporarily deployed to docker-publish October 12, 2023 06:12 — with GitHub Actions Inactive
@banterCZ banterCZ requested a review from zcgandcomp October 12, 2023 06:14
docs/Mobile-Utility-Server-1.5.0.md Outdated Show resolved Hide resolved
docs/Mobile-Utility-Server-1.5.0.md Show resolved Hide resolved
docs/Mobile-Utility-Server-1.5.0.md Outdated Show resolved Hide resolved
@banterCZ banterCZ temporarily deployed to docker-publish October 13, 2023 05:09 — with GitHub Actions Inactive
@banterCZ banterCZ temporarily deployed to docker-publish October 13, 2023 05:43 — with GitHub Actions Inactive
Output will look like this:

```
DH4v3SCoDRDUAFBD
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole section Creating First Admin User is analog to documentation in PowerAuth-Cloud, but I afraid that users may tend to use this concrete value instead of their randomly generated ones. cc @romanstrobl

@banterCZ banterCZ temporarily deployed to docker-publish October 13, 2023 05:52 — with GitHub Actions Inactive
@banterCZ banterCZ requested a review from zcgandcomp October 13, 2023 05:53
Copy link
Member

@zcgandcomp zcgandcomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with it.

Copy link
Member

@korbelm korbelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banterCZ banterCZ merged commit fa59987 into develop Oct 18, 2023
@banterCZ banterCZ deleted the issues/137-after-sql branch October 18, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants