Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UserAgent null-safe and return optional instead #230

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Make UserAgent null-safe and return optional instead #230

merged 1 commit into from
Nov 16, 2023

Conversation

banterCZ
Copy link
Member

Follow-up to #217

petrdvorak
petrdvorak approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@petrdvorak petrdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

Could we remove the Serializable along the way?

@banterCZ
Copy link
Member Author

Looks OK.

Could we remove the Serializable along the way?

Sure, but in a separate PR 😉 #231

@banterCZ banterCZ mentioned this pull request Nov 16, 2023
Closed
romanstrobl
romanstrobl approved these changes Nov 16, 2023
View reviewed changes
Copy link
Member

@romanstrobl romanstrobl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

@banterCZ banterCZ force-pushed the issues/217-user-agent-optional branch from 28aee2b to 11a5459 Compare November 16, 2023 08:44
@banterCZ banterCZ merged commit d331578 into develop Nov 16, 2023
4 checks passed
@banterCZ banterCZ deleted the issues/217-user-agent-optional branch November 16, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanstrobl romanstrobl romanstrobl approved these changes

@petrdvorak petrdvorak petrdvorak approved these changes

@jandusil jandusil Awaiting requested review from jandusil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@banterCZ @petrdvorak @romanstrobl