Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #226: Make Device from UserAgent class Serializable #227

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Fix #226: Make Device from UserAgent class Serializable #227

merged 1 commit into from
Nov 15, 2023

Conversation

jandusil
Copy link
Contributor

@jandusil jandusil commented Nov 12, 2023 •
edited
Loading

@jandusil jandusil requested a review from banterCZ November 12, 2023 14:58
@jandusil jandusil self-assigned this Nov 12, 2023
@jandusil jandusil linked an issue Nov 12, 2023 that may be closed by this pull request
Make Device from UserAgent class Serializable #226
Closed
@jandusil jandusil requested a review from zcgandcomp November 12, 2023 14:58
petrdvorak
petrdvorak approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@petrdvorak petrdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@jandusil jandusil mentioned this pull request Nov 12, 2023
Closed
banterCZ
banterCZ approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@banterCZ banterCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@jandusil jandusil merged commit e3aa3ff into develop Nov 15, 2023
4 checks passed
@jandusil jandusil deleted the issues/226-serializable-device branch November 22, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@banterCZ banterCZ banterCZ approved these changes

@petrdvorak petrdvorak petrdvorak approved these changes

@zcgandcomp zcgandcomp Awaiting requested review from zcgandcomp

Assignees

@jandusil jandusil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Device from UserAgent class Serializable
3 participants
@jandusil @petrdvorak @banterCZ