Merge pull request #856 from /issues/773-upload-failed-selfie

Fix #773: Upload presence check photo for failed authentication attempts
wultra · Sep 8, 2023 · 4946b20 · 4946b20
2 parents c5cb634 + 6854c92
commit 4946b20
Showing 1 changed file with 19 additions and 13 deletions.
diff --git a/...ultra/app/onboardingserver/presencecheck/iproov/provider/IProovPresenceCheckProvider.java b/...ultra/app/onboardingserver/presencecheck/iproov/provider/IProovPresenceCheckProvider.java
@@ -185,23 +185,29 @@ public PresenceCheckResult getResult(OwnerId id, SessionInfo sessionInfo) throws
             throw new RemoteCommunicationException("Missing response body when validating a verification in iProov, " + id);
         }
 
-        final PresenceCheckResult result = new PresenceCheckResult();
-
         final ClaimValidateResponse response = parseResponse(responseEntity.getBody(), ClaimValidateResponse.class);
-        if (response.getPassed()) {
-            result.setStatus(PresenceCheckStatus.ACCEPTED);
+        return convert(response, id);
+    }
 
-            if (ifFrameAvailable(response)) {
-                logger.debug("Parsing frame image {}", id);
-                result.setPhoto(parseImage(response.getFrame()));
-            } else {
-                logger.debug("Frame is not available, {}", id);
-            }
+    private static PresenceCheckResult convert(final ClaimValidateResponse source, final OwnerId id) {
+        final PresenceCheckResult target = new PresenceCheckResult();
+
+        if (source.getPassed()) {
+            target.setStatus(PresenceCheckStatus.ACCEPTED);
         } else {
-            result.setStatus(PresenceCheckStatus.REJECTED);
-            result.setRejectReason(response.getReason());
+            logger.debug("Image rejected with reason={}, {}", source.getReason(), id);
+            target.setStatus(PresenceCheckStatus.REJECTED);
+            target.setRejectReason(source.getReason());
         }
-        return result;
+
+        if (ifFrameAvailable(source)) {
+            logger.debug("Parsing frame image {}", id);
+            target.setPhoto(parseImage(source.getFrame()));
+        } else {
+            logger.debug("Frame is not available, {}", id);
+        }
+
+        return target;
     }
 
     @Override