Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various suggested fixes #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

thomasvs
Copy link

No description provided.

Thomas Vander Stichele and others added 6 commits September 12, 2011 19:58
@wulczer
Copy link
Owner

wulczer commented Mar 24, 2012

You master branch did not merge cleanly, but I cherry-picked and pushed most of the commits, except 6bd04c8 and 6485bc0.

As of today, this fork supports WebSocket protocol 8 and 13. If you tried with something that uses version 7 (Firefox 6 AFAICS), I'll make it recognize version 7 as well.

Thanks!

@thomasvs
Copy link
Author

thomasvs commented Apr 1, 2012

On Sat, 2012-03-24 at 10:37 -0700, Jan Urbański wrote:

You master branch did not merge cleanly, but I cherry-picked and pushed most of the commits, except 6bd04c8

that was one you told me to try back in the day (it may indeed have been
firefox 6) and it worked for me. Any reason not to apply it ?

and 6485bc0.

That one is already on your master, no ? I think I cherry-picked that to
make it work again when I recently tried it again.

Thomas

As of today, this fork supports WebSocket protocol 8 and 13. If you tried with something that uses version 7 (Firefox 6 AFAICS), I'll make it recognize version 7 as well.

Thanks!


Reply to this email directly or view it on GitHub:
#3 (comment)

  • You can't just tell a falcon when to hunt.
  • Actually you can... there's a whole sport built around it.
    Falconry.

Flumotion - the only way to stream!
http://www.flumotion.net/

@wulczer
Copy link
Owner

wulczer commented Apr 2, 2012

6bd04c8 did not merge cleanly, the server currently accepts procotol version 8 and 13, and the patch assumes it accepts only 8 and changes it to 7 and 8.

Make a patch that does 8, 13 -> 7, 8, 13 and I can merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants