Skip to content

Commit

Permalink
More optimized defaults
Browse files Browse the repository at this point in the history
  • Loading branch information
krystian-panek-vmltech committed Nov 29, 2023
1 parent b3062fd commit b9963c1
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ instance:
# Time to wait for next state checking
interval: 6s
# Number of successful check attempts that indicates end of checking
done_threshold: 5
done_threshold: 4
# Max time to wait for the instance to be healthy after executing the start script or e.g deploying a package
await_started:
timeout: 30m
Expand Down
4 changes: 2 additions & 2 deletions examples/docker/src/aem/default/etc/aem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ instance:
# Time to wait for next state checking
interval: 6s
# Number of successful check attempts that indicates end of checking
done_threshold: 5
done_threshold: 4
# Max time to wait for the instance to be healthy after executing the start script or e.g deploying a package
await_started:
timeout: 30m
Expand Down Expand Up @@ -96,7 +96,7 @@ instance:
component_stable:
skip: false
pids_ignored: []
pids_failed_activation: ["*"]
pids_failed_activation: []
pids_unsatisfied_reference: []
# Sling Installer tracking
installer:
Expand Down
4 changes: 2 additions & 2 deletions pkg/cfg/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func (c *Config) setDefaults() {
v.SetDefault("instance.check.skip", false)
v.SetDefault("instance.check.warmup", time.Second*1)
v.SetDefault("instance.check.interval", time.Second*6)
v.SetDefault("instance.check.done_threshold", 5)
v.SetDefault("instance.check.done_threshold", 4)
v.SetDefault("instance.check.installer.state", true)
v.SetDefault("instance.check.installer.pause", true)

Expand All @@ -66,7 +66,7 @@ func (c *Config) setDefaults() {

v.SetDefault("instance.check.component_stable.skip", false)
v.SetDefault("instance.check.component_stable.pids_ignored", []string{})
v.SetDefault("instance.check.component_stable.pids_failed_activation", []string{"*"})
v.SetDefault("instance.check.component_stable.pids_failed_activation", []string{})
v.SetDefault("instance.check.component_stable.pids_unsatisfied_reference", []string{})

v.SetDefault("instance.check.installer.skip", false)
Expand Down
4 changes: 2 additions & 2 deletions pkg/project/app_classic/aem/default/etc/aem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ instance:
# Time to wait for next state checking
interval: 6s
# Number of successful check attempts that indicates end of checking
done_threshold: 5
done_threshold: 4
# Wait only for those instances whose state has been changed internally (unaware of external changes)
await_strict: true
# Max time to wait for the instance to be healthy after executing the start script or e.g deploying a package
Expand Down Expand Up @@ -98,7 +98,7 @@ instance:
component_stable:
skip: false
pids_ignored: []
pids_failed_activation: ["*"]
pids_failed_activation: []
pids_unsatisfied_reference: []
# Sling Installer tracking
installer:
Expand Down
5 changes: 3 additions & 2 deletions pkg/project/app_cloud/aem/default/etc/aem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ instance:
# Time to wait for next state checking
interval: 6s
# Number of successful check attempts that indicates end of checking
done_threshold: 5
done_threshold: 4
# Wait only for those instances whose state has been changed internally (unaware of external changes)
await_strict: true
# Max time to wait for the instance to be healthy after executing the start script or e.g deploying a package
Expand All @@ -74,6 +74,7 @@ instance:
timeout: 10m
# Max time in which socket connection to instance should be established
reachable:
skip: false
timeout: 3s
# Bundle state tracking
bundle_stable:
Expand All @@ -95,7 +96,7 @@ instance:
component_stable:
skip: false
pids_ignored: []
pids_failed_activation: ["*"]
pids_failed_activation: []
pids_unsatisfied_reference: []
# Sling Installer tracking
installer:
Expand Down
4 changes: 2 additions & 2 deletions pkg/project/instance/aem/default/etc/aem.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ instance:
# Time to wait for next state checking
interval: 6s
# Number of successful check attempts that indicates end of checking
done_threshold: 5
done_threshold: 4
# Max time to wait for the instance to be healthy after executing the start script or e.g deploying a package
await_started:
timeout: 30m
Expand Down Expand Up @@ -96,7 +96,7 @@ instance:
component_stable:
skip: false
pids_ignored: []
pids_failed_activation: ["*"]
pids_failed_activation: []
pids_unsatisfied_reference: []
# Sling Installer tracking
installer:
Expand Down

0 comments on commit b9963c1

Please sign in to comment.