Removing jms polling consumer reference from jms task to avoid dangli…

…ng consumers in broker side Fixes #3460
wso2 · Aug 20, 2024 · 6820d7b · 6820d7b
1 parent c655319
commit 6820d7b
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...inbound.endpoint/src/main/java/org/wso2/carbon/inbound/endpoint/protocol/jms/JMSTask.java b/...inbound.endpoint/src/main/java/org/wso2/carbon/inbound/endpoint/protocol/jms/JMSTask.java
@@ -43,7 +43,11 @@ public JMSTask(JMSPollingConsumer jmsPollingConsumer, long interval) {
 
  protected void taskExecute() {
  logger.debug("Executing JMS Task Execution.");
- jmsPollingConsumer.execute();
+ if (jmsPollingConsumer != null) {
+ jmsPollingConsumer.execute();
+ } else {
+ logger.error("JMS Polling Consumer is closed. Cannot execute the task.");
+ }
  }
 
  @Override
@@ -58,6 +62,8 @@ public void init(SynapseEnvironment synapseEnvironment) {
  public void destroy() {
  logger.debug("Destroying JMS Task.");
  jmsPollingConsumer.destroy();
+ // removing the consumer reference to avoid dangling consumers in broker side.
+ jmsPollingConsumer = null;
  }
 
  /**