Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the revert Branding confirmation and default app-wise branding messages #6976

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

savindi7
Copy link
Contributor

@savindi7 savindi7 commented Oct 11, 2024

Purpose

Add a generic revert branding confirmation message to all use cases including B2B scenarios.

Screenshot 2024-10-11 at 19 27 21

Add notification message to inform on the default branding set when app-wise branding is not applied.

Screenshot 2024-10-12 at 08 31 25

Related Issues

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.79%. Comparing base (8f7beb2) to head (bbe9190).
Report is 20 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6976   +/-   ##
=======================================
  Coverage   31.79%   31.79%           
=======================================
  Files          41       41           
  Lines         890      890           
  Branches      204      220   +16     
=======================================
  Hits          283      283           
+ Misses        607      557   -50     
- Partials        0       50   +50     
Flag Coverage Δ
@wso2is/core 31.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

@savindi7 savindi7 changed the title Improve the revert Branding confirmation message Improve the revert Branding confirmation and default app-wise branding messages Oct 12, 2024
@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@savindi7 savindi7 merged commit 04dbfce into wso2:master Oct 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants