Add legacy application token section #6783
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Achintha444
reviewed
Aug 16, 2024
| <ol> | ||
| <li> | ||
| <strong>Client Application Changes:</strong> | ||
| <p>Update your client application to no longer use the |
There was a problem hiding this comment.
use the needs space after.
|
Suggestion for the design:
|
Comment on lines
298
to
299
| const useClientIdAsSubClaimForAppTokensEle: MutableRefObject<HTMLElement> = useRef<HTMLElement>(); | ||
| const omitUsernameInIntrospectionRespForAppTokensEle: MutableRefObject<HTMLElement> = useRef<HTMLElement>(); |
There was a problem hiding this comment.
Suggested change
| const useClientIdAsSubClaimForAppTokensEle: MutableRefObject<HTMLElement> = useRef<HTMLElement>(); | |
| const omitUsernameInIntrospectionRespForAppTokensEle: MutableRefObject<HTMLElement> = useRef<HTMLElement>(); | |
| const useClientIdAsSubClaimForAppTokensElement: MutableRefObject<HTMLElement> = useRef<HTMLElement>(); | |
| const omitUsernameInIntrospectionRespForAppTokensElement: MutableRefObject<HTMLElement> = useRef<HTMLElement>(); |
| <Trans | ||
| i18nKey={ t("actions:fields.authentication.info.message") } | ||
| > | ||
| You currently using an outdated behavior for application tokens. |
There was a problem hiding this comment.
Suggested change
| You currently using an outdated behavior for application tokens. | |
| You are currently using an outdated behavior for application tokens. |
| <Trans | ||
| i18nKey={ t("actions:fields.authentication.info.message") } | ||
| > | ||
| You currently using an outdated behavior for application tokens. |
There was a problem hiding this comment.
Using you in UI instructions is generally not recommended. Hope we can get the text reviewed with the doc team.
| <li> | ||
| <strong>Client Application Changes:</strong> | ||
| <p>Update your client application to no longer use the | ||
| <code>sub</code> claim to refer to the application |
There was a problem hiding this comment.
claim is too technical for an average user. we can use attribute instead.
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
10 tasks
| <Trans | ||
| i18nKey={ t("actions:fields.authentication.info.message") } | ||
| > | ||
| You are currently using an outdated behavior for application tokens. |
There was a problem hiding this comment.
Better if we can get the text reviewed by the doc team?
|
This will track from #6813 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR will add a Legacy Application token sention to maintain the below configs.
The initial UI design is as follows.
Please feel free to make suggestions for the design.
Related Issues
Checklist
Security checks