Improve tenant resolving with tenant qualified URL enabled #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhagyasakalanka
previously approved these changes
Oct 16, 2023
chamathns
reviewed
Oct 16, 2023
...ty.api.user.common/src/main/java/org/wso2/carbon/identity/api/user/common/ContextLoader.java
Outdated
Show resolved
Hide resolved
Thisara-Welmilla
force-pushed
the
improve-tenant-qualified-URL
branch
from
108da4c
to
95dd444
Compare
|
PR builder started |
|
PR builder completed |
Thisara-Welmilla
force-pushed
the
improve-tenant-qualified-URL
branch
3 times, most recently
from
30ee888
to
1f40fbc
Compare
Thisara-Welmilla
force-pushed
the
improve-tenant-qualified-URL
branch
from
1f40fbc
to
2aa6620
Compare
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6529761800
chamathns
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
carbon.superto URL when tenant qualified URL is enabled. product-is#16906Improve resolving tenant domain when tenant qualified URL feature is enabled. If the tenant domain is available in the context retrieve it otherwise retrieve tenant domain from the privileged carbon context.