Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add User Account Recovery V2 API #179

Merged
merged 18 commits into from
Sep 27, 2023
Merged

Add User Account Recovery V2 API #179

merged 18 commits into from
Sep 27, 2023

Conversation

Rashmini
Copy link
Contributor

@Rashmini Rashmini commented Aug 31, 2023 •
edited
Loading

Purpose

Due to the encountered issues with the current V1 API, V2 API is implemented with the following changes.

  • A unique identifier(UUID) will be generated for a particular password recovery attempt which is bound to a particular user at the recovery initiation (/init). This will not be changed in the rest of the flow.
  • Responses of the /recover and /resend requests will contain the above flow confirmation code.
  • In the OTP based recovery scenarios, above flow confirmation code should be passed as the confirmationCode property and the received OTP should be passed as the otp property in the /confirm request. In the email link based recovery, confirmationCode should be the code received to the email of the user.
  • In the /reset request, UUID generated at the recovery initiation should be passed as the flowConfirmationCode and the resetCode received from the above request should be passed.
  • OTP validation is happened for the submitted OTP against the recovery context data retrieved from the recovery flow confirmation code in the request.

Related Issue: wso2/product-is#16536

When should this PR be merged

This should be merged after wso2-extensions/identity-governance#751

@Rashmini Rashmini mentioned this pull request Aug 31, 2023
Closed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6245210673

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6245210673
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Sep 20, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6245210673

pulasthi7
pulasthi7 reviewed Sep 21, 2023
View reviewed changes
...v2/src/main/java/org/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/Constants.java Show resolved Hide resolved
...va/org/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/PasswordRecoveryService.java Outdated Show resolved Hide resolved
...g/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/exceptions/ConflictException.java Outdated Show resolved Hide resolved
...in/java/org/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/utils/RecoveryUtil.java Outdated Show resolved Hide resolved
...in/java/org/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/utils/RecoveryUtil.java Outdated Show resolved Hide resolved
...in/java/org/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/utils/RecoveryUtil.java Outdated Show resolved Hide resolved
...in/java/org/wso2/carbon/identity/rest/api/user/recovery/v2/impl/core/utils/RecoveryUtil.java Show resolved Hide resolved
@Rashmini Rashmini merged commit 9f39c84 into wso2:master Sep 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pulasthi7 pulasthi7 pulasthi7 left review comments

@pamodaaw pamodaaw pamodaaw approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rashmini @jenkins-is-staging @pulasthi7 @pamodaaw