Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor action execution request data model #6022

Merged
merged 5 commits into from
Oct 13, 2024

Conversation

Shenali-SJ
Copy link
Contributor

Description

This PR updateds the action execution component by refactoring the data types of the additionalHeaders and additionalParams fields in the action request object to align with the API contract.

Updated request object:

{
    "additionalHeaders": [
        {
            "name": "accept",
            "value": [
                "application/json"
            ]
        },
        {
            "name": "cache-control",
            "value": [
                "no-cache"
            ]
        }
    ],
    "additionalParams": [
        {
            "name": "TestParam",
            "value": [
                "test"
            ]
        }
    ],
    "clientId": "r***************************a",
    "grantType": "client_credentials",
    "scopes": [
        "test_scope_1",
        "test_scope_2"
    ]
}

Related Issue:

Related PRs:

Followup Actions:

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 40.10%. Comparing base (9715437) to head (d5218fd).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
...arbon/identity/action/execution/model/Request.java 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6022      +/-   ##
============================================
- Coverage     40.17%   40.10%   -0.07%     
- Complexity    14172    14179       +7     
============================================
  Files          1734     1736       +2     
  Lines        116863   117262     +399     
  Branches      20081    20153      +72     
============================================
+ Hits          46953    47033      +80     
- Misses        62694    62991     +297     
- Partials       7216     7238      +22     
Flag Coverage Δ
unit 23.94% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@malithie malithie merged commit e0df713 into wso2:master Oct 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants