Enable API Resources APIs for organization level #6002
+319
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanChathusanda93
force-pushed
the
org-path-api-res-branch
branch
2 times, most recently
from
8a510db
to
39fa1e2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6002 +/- ##
============================================
+ Coverage 39.62% 40.15% +0.53%
+ Complexity 14299 14161 -138
============================================
Files 1733 1734 +1
Lines 119948 117033 -2915
Branches 19808 19328 -480
============================================
- Hits 47525 46992 -533
+ Misses 65115 62818 -2297
+ Partials 7308 7223 -85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShanChathusanda93
force-pushed
the
org-path-api-res-branch
branch
from
39fa1e2
to
1dba26c
Compare
AnuradhaSK
reviewed
Oct 13, 2024
Comment on lines
+1263
to
+1264
| return filterQueryBuilder.getFilterAttributeValue().get(1).contains("internal") || | ||
| filterQueryBuilder.getFilterAttributeValue().get(1).contains("console"); |
There was a problem hiding this comment.
Don't we have an existing constant for internal and console?
AnuradhaSK
reviewed
Oct 13, 2024
| @@ -445,6 +475,18 @@ public List<Scope> getScopesByTenantId(Integer tenantId, List<ExpressionNode> ex | |||
| appendFilterQuery(expressionNodes, filterQueryBuilder, true); | |||
| String query = SQLConstants.GET_SCOPES_BY_TENANT_ID + filterQueryBuilder.getFilterQuery() + | |||
| SQLConstants.GET_SCOPES_BY_TENANT_ID_TAIL; | |||
| try { | |||
| if (OrganizationManagementUtil.isOrganization(tenantId) && !isInternalFiltering(filterQueryBuilder)) { | |||
There was a problem hiding this comment.
According to the logic in isInternalFiltering method, internal_org.. scopes also get considered , is that means internal_org.. scopes can't be searched ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Follow up actions