Remove sun.java dependency #5980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5980 +/- ##
=============================================
- Coverage 39.50% 23.81% -15.69%
+ Complexity 13894 6380 -7514
=============================================
Files 1733 1561 -172
Lines 117138 99247 -17891
Branches 18902 15213 -3689
=============================================
- Hits 46275 23636 -22639
- Misses 63773 72257 +8484
+ Partials 7090 3354 -3736
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
indeewari
previously approved these changes
Oct 2, 2024
...wso2.carbon.identity.core/src/main/java/org/wso2/carbon/identity/core/util/IdentityUtil.java
Show resolved
Hide resolved
indeewari
reviewed
Oct 2, 2024
....carbon.identity.core/src/test/java/org/wso2/carbon/identity/core/util/IdentityUtilTest.java
Outdated
Show resolved
Hide resolved
indeewari
approved these changes
Oct 3, 2024
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11156995360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sun.java implementation has been changed with JDK21 therefore removing it