Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix previous validation error persist in static variable #5968

Merged

Conversation

sadilchamishka
Copy link
Contributor

$subject

The validation bean which keeps the errors shouldn't be a static variable, it should be an instance variable. But the way it has been implemented cause this issue.

Using instance variable from static methods are not allowed. Hence deprecated the below two static methods, and introduced new methods which are instance level.

  • getCustomErrorMessagesWhenRegistering -> retrieveCustomErrorMessagesForRegistration
  • getCustomErrorMessagesToVerifyCode -> getCustomErrorMessagesForCodeVerification

Related Issues

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11101400781

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 67.07317% with 27 lines in your changes missing coverage. Please review.

Project coverage is 23.55%. Comparing base (03355b8) to head (6ce866c).
Report is 43 commits behind head on master.

Files with missing lines Patch % Lines
.../identity/mgt/util/UserIdentityManagementUtil.java 74.60% 8 Missing and 8 partials ⚠️
...y/mgt/services/UserInformationRecoveryService.java 42.10% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5968      +/-   ##
============================================
+ Coverage     23.40%   23.55%   +0.14%     
- Complexity     6272     6324      +52     
============================================
  Files          1561     1561              
  Lines         99251    99326      +75     
  Branches      15190    15218      +28     
============================================
+ Hits          23232    23395     +163     
+ Misses        72751    72606     -145     
- Partials       3268     3325      +57     
Flag Coverage Δ
unit 23.55% <67.07%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11101400781
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11101400781

@sadilchamishka sadilchamishka merged commit 107d65e into wso2:master Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants