Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue of not storing policy order in RegistryPolicyPersistenceManager implementation #5961

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Fix the issue of not storing policy order in RegistryPolicyPersistenceManager implementation #5961

merged 2 commits into from
Sep 28, 2024

Conversation

UdeshAthukorala
Copy link
Contributor

Proposed changes in this pull request

$Subject

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11070130643

@codecov Codecov
Copy link

codecov bot commented Sep 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.34%. Comparing base (ccc2502) to head (fd1f118).
Report is 8 commits behind head on master.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #5961      +/-   ##
============================================
+ Coverage     23.31%   23.34%   +0.02%     
- Complexity     6255     6261       +6     
============================================
  Files          1561     1561              
  Lines         99253    99251       -2     
  Branches      15190    15190              
============================================
+ Hits          23145    23166      +21     
+ Misses        72835    72813      -22     
+ Partials       3273     3272       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

darshanasbg
darshanasbg reviewed Sep 27, 2024
View reviewed changes
.../java/org/wso2/carbon/identity/entitlement/persistence/RegistryPolicyPersistenceManager.java Outdated
@@ -23,6 +23,7 @@
import org.apache.commons.lang.StringUtils;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.opensaml.soap.wstrust.OnBehalfOf;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresssed with https://github.com/wso2/carbon-identity-framework/compare/08439fd00913ce4e8ba91e43542556b527b86bcd..0db7215142108335aa10179b969b214ed06fa884

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11070130643
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11074452964

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11074452964
Status: failure

darshanasbg
darshanasbg previously approved these changes Sep 28, 2024
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11081483721

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11081483721
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Sep 28, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11081483721

@UdeshAthukorala UdeshAthukorala merged commit 560d4a6 into wso2:master Sep 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshanasbg darshanasbg darshanasbg approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@Yoshani Yoshani Awaiting requested review from Yoshani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UdeshAthukorala @jenkins-is-staging @darshanasbg