[Feature] APIM Portal Notifications #12438
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
...mgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/ApiMgtDAO.java
Outdated
Show resolved
Hide resolved
....carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/PortalNotificationDAO.java
Outdated
Show resolved
Hide resolved
....carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/PortalNotificationDAO.java
Outdated
Show resolved
Hide resolved
...carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/dao/constants/SQLConstants.java
Outdated
Show resolved
Hide resolved
...in/java/org/wso2/carbon/apimgt/impl/portalNotifications/WorkflowNotificationServiceImpl.java
Outdated
Show resolved
Hide resolved
prasa7
reviewed
Jun 12, 2024
| } | ||
| } catch (SQLException e) { | ||
| conn.rollback(); | ||
| handleException("Failed to delete notification by id", e); |
There was a problem hiding this comment.
Add notification id and other context information to the log messages.
prasa7
reviewed
Jun 12, 2024
| @Override | ||
| public NotificationMetaData getNotificationMetaData(WorkflowDTO workflowDTO) { | ||
| NotificationMetaData notificationMetaData = new NotificationMetaData(); | ||
|
|
prasa7
reviewed
Jun 12, 2024
| } | ||
| } | ||
| } catch (APIManagementException e) { | ||
| APIUtil.handleException("Error while getting API usage by API ID - getAPIUsageByAPIId()", e); |
There was a problem hiding this comment.
Add API ID as the context information for the message. Check all the messages and add context information.
prasa7
reviewed
Jun 12, 2024
| String apiUUID = null; | ||
| try { | ||
| apiUUID = getAPIUUIDUsingNameContextVersion(apiName, apiContext, apiVersion, tenantDomain); | ||
| APIIdentifier apiIdEmailReplaced = new APIIdentifier(APIUtil.replaceEmailDomain(provider), apiName, |
There was a problem hiding this comment.
@tharindu1st Are we using APIIdentifers ?
prasa7
reviewed
Jun 12, 2024
| notificationMetaData.setRequestedTier( | ||
| workflowDTO.getProperties(APIConstants.PortalNotifications.REQUESTED_TIER)); | ||
| notificationMetaData.setComment(workflowDTO.getComments()); | ||
|
|
prasa7
reviewed
Jun 12, 2024
| import org.wso2.carbon.apimgt.impl.systemNotifications.NotificationType; | ||
| import org.wso2.carbon.apimgt.impl.utils.APIMgtDBUtil; | ||
|
|
||
| import java.sql.*; |
prasa7
requested changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.