Improve Exception Handling and Add Unit Tests for API based Authentication #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DMHP
approved these changes
Nov 6, 2023
AnuradhaSK
reviewed
May 12, 2024
| ErrorMessages.INVALID_JWT_TOKEN.getMessage()); | ||
| } catch (IdentityOAuth2Exception e) { | ||
| throw new AuthenticationFailedException(ErrorMessages.JWT_TOKEN_VALIDATION_FAILED.getCode(), | ||
| ErrorMessages.JWT_TOKEN_VALIDATION_FAILED.getMessage(), e); |
There was a problem hiding this comment.
Seems the message's alias placeholder (%s) is not getting replaced
There was a problem hiding this comment.
This error message (JWT_TOKEN_VALIDATION_FAILED) refers to the string "JWT token validation Failed." which does not contain a place holder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
validateJWTToken()method are differentiated whether they are client or server exceptions and handheld accordingly.isTrustedTokenIssuer()method.OpenIDConnectAuthenticatorTestandOIDCTokenValidationUtilTestclasses in order to verify API based authentication functionality of the OIDC authenticator.