Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement title card options #204

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Conversation

KamiliaBlow
Copy link
Contributor

@KamiliaBlow KamiliaBlow commented Jun 13, 2024

Closes the issue #203

Changes:

  • Deleted the file title_cards_dialog.html (it is not used)
  • Slightly improved UI for title card input menu
  • Added ability to change font color in HEX + settings
  • Added customization so you can speed up or slow down the text zoom + settings
  • Now if the file path for Logo is missing, you can use the new input fields to display text instead of Logo image + size settings

Problem:

  • Need to manually add new localization strings for other languages

- Deleted the file title_cards_dialog.html (it is not used)
- Slightly improved UI for title card entry
- Added ability to change font color in HEX (added to settings)
- Added customization so you can speed up or slow down the text zoom
- Need to manually add new localization strings for other languages
@wrycu
Copy link
Owner

wrycu commented Jun 13, 2024

@KamiliaBlow thanks for the PR!

@arknano I don't actually use this feature. Can you please review these changes and provide feedback?

My only note is that it significantly changes the font sizes even if you don't use the new functionality.

Old format (captured a bit late so the coloring is dumb - ignore that)

image

New format

image

@KamiliaBlow
Copy link
Contributor Author

Given that we can change the text size in the settings, I don't see much of a problem with the basic settings. (The logo suggests long words for the top margin and 1-2 words for the bottom margin. I used "The book of boba fett" as an example)

@wrycu
Copy link
Owner

wrycu commented Jun 14, 2024

I don't mean it as a bad thing; just wanted to call it out as a default behavior change. As I said, I personally don't use it.

I'll let @arknano comment when he eventually wakes up.

@arknano
Copy link
Contributor

arknano commented Jun 14, 2024

Fantastic stuff, thanks for improving the feature! I did intend all these features but got very lazy once I had the basic part in haha

One tiny improvement I'd suggest is just making it clear in the dialog that the logo text only works if there's no logo defined, it as it's a bit unintuitive to just have some fields that do nothing in certain circumstances! Not a big deal though

I'm ok with the change to defaults after testing it myself, the original defaults were kind of made up to be fair.

- Added a tooltip in the input field, for the logo
- Fixed a small bug with h2
@wrycu wrycu merged commit 868366b into wrycu:main Jun 14, 2024
1 of 2 checks passed
@wrycu
Copy link
Owner

wrycu commented Jun 14, 2024

Thanks for the review @arknano and thanks for the PR, @KamiliaBlow!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants