Merge pull request #175 from arknano/cleanup-settings-title

fix(settings): standardise popup settings window titles
wrycu · Jan 31, 2024 · dc142e7 · dc142e7
2 parents f81babb + 4902d78
commit dc142e7
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/scripts/animation.js b/scripts/animation.js
@@ -452,7 +452,7 @@ class attack_animation_UISettings extends FormApplication {
         return mergeObject(super.defaultOptions, {
             id: "data-importer",
             classes: ["starwarsffg", "data-import"],
-            title: `${game.i18n.localize("SWFFG.UISettingsLabel")}`,
+            title: `${game.i18n.localize("ffg-star-wars-enhancements.attack-animation.ui.name")}`,
             template: "modules/ffg-star-wars-enhancements/templates/settings.html",
         });
     }

diff --git a/scripts/opening_crawl.js b/scripts/opening_crawl.js
@@ -375,7 +375,7 @@ class opening_crawl_UISettings extends FormApplication {
         return mergeObject(super.defaultOptions, {
             id: "data-importer",
             classes: ["starwarsffg", "data-import"],
-            title: `${game.i18n.localize("SWFFG.UISettingsLabel")}`,
+            title: `${game.i18n.localize("ffg-star-wars-enhancements.opening-crawl.ui.name")}`,
             template: "modules/ffg-star-wars-enhancements/templates/settings.html",
         });
     }

diff --git a/templates/settings.html b/templates/settings.html
@@ -58,7 +58,6 @@
 <form autocomplete="off" class="flexcol">
     <section class="content" id="config-tabs">
         <div class="settings-list">
-            <h2 class="module-header">{{ localize data.system.title }}</h2>
             {{#each data.system.menus}} {{> menuPartial}} {{/each}} {{#each data.system.settings}} {{> settingPartialCustom}}
             {{else}}
             <p class="notes">{{localize 'SETTINGS.None'}}</p>