Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): handle components multiselection - Wf-148 #707

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

madeindjs
Copy link
Collaborator

@madeindjs madeindjs commented Dec 19, 2024

In builder manager, I

  1. transform state.selection to an array of selected items
  2. introduce ssbm.appendSelection and ssbm.getSelectedIds (ssbm.getSelectId return the first selection)
  3. replace ssbm.getSelectId() === componentId by ssbm.isComponentIdSelected(componentId)
  4. check key press during BuilderApp selection add, if is pressed , call appendSelection
  5. introduced a selectionStatus which can be Single | Multiple | None

Screenshots

UI builder

Screen.Recording.2024-12-19.at.17.45.42.mov

Workflow

Screen.Recording.2024-12-20.at.15.37.11.mov

const { x, y } = tempXY;
changeCoordinates(nodeId, x, y);
temporaryNodeCoordinates.value[nodeId] = null;
changeCoordinatesMultiple(temporaryNodeCoordinates.value);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big brain move

@madeindjs madeindjs marked this pull request as ready for review December 23, 2024 09:17
@ramedina86 ramedina86 merged commit dc8618b into writer:dev Jan 7, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants