Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change object parameter for Chat to comply with Pydantic validation #653

Merged
merged 5 commits into from
Nov 29, 2024

Conversation

mmikita95
Copy link
Contributor

After SDK update tests AI module tests began to fail because of this validation. This fix addresses that by providing correct object parameter.

@ramedina86
Copy link
Collaborator

@mmikita95 have we switched the SDK version in the toml though?

@mmikita95
Copy link
Contributor Author

Done! Not sure whether we really need this in this particular case, but let's do it nevertheless 😄

@ramedina86
Copy link
Collaborator

I'd just like to make sure your environment where you're developing matches the toml, just to reduce surprises!

@ramedina86
Copy link
Collaborator

can you change toml to SDK 1.5 and check everything on your side?

@ramedina86 ramedina86 merged commit a485084 into writer:dev Nov 29, 2024
15 checks passed
@mmikita95 mmikita95 deleted the fix-ai-tests-object branch December 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants