fix: the process of saving project information stops properly in any condition - WF-114 #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FabienArcellier
force-pushed
the
WF-114-the-process-of-saving-project-information-stops-in-a-predictable-manner
branch
from
8874132 to
9668c6b
Compare
FabienArcellier
force-pushed
the
WF-114-the-process-of-saving-project-information-stops-in-a-predictable-manner
branch
from
9668c6b to
c3e71e4
Compare
|
Yes seems cleaner and more reliable 👍 |
ramedina86
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The process can be stuck or stop with an exception. I migrate it to use
multiprocessing.Eventto trigger stop from inside and avoid killing from outside without control.